x938 - Changes to fix cypress test flaking #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seenanair
reviewed
Oct 26, 2022
| @@ -13,6 +13,9 @@ jobs: | |||
| cypress: | |||
| name: Run cypress tests | |||
| runs-on: ubuntu-latest | |||
| container: | |||
| image: cypress/browsers:node16.17.1-chrome106-ff105-edge | |||
| options: --user 1001 | |||
There was a problem hiding this comment.
What is --user 1001 indicates?
There was a problem hiding this comment.
There was a permissions issue with the docker container. This discussion here outlines the issue and temporary fix.
seenanair
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #227
Previously cypress was running off electron, in theory this could have caused the difference in github CI to local tests as locally we use chrome.
Running off chrome appears to make the tests 1-2 mins slower.
In future we may need to upgrade the docker image to the latest versions of chrome using https://github.com/cypress-io/cypress-docker-images
Flakiness is difficult to test but so far this PR has passed 5/5 re-runs of cypress tests.