DPL-1056 - Removed breaking restriction

[SHIV5T3R]

Closes #701

Changes proposed in this pull request

• Removed a restriction that would prevent new locations from being added if the same location type was being used

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

[dasunpubudumal]

@SHIV5T3R the change looks good.

A small thing; the README.md doesn't have any instruction on setting up bunny.yml file. I imagine one has to go to the workflow (in .github directory) to find out how to utilise it. When I was first setting it up, I ran to an error saying the bunny.yml was not found.

Do you think that we could improve the README.md to include instructions on the bunny.yml file?

[KatyTaylor]

Looks good.

On the related story, Harry wrote:

After removing this, the behaviour is still the same as previously .... Another room with the same name cannot be created, because of the validation validates :name, presence: true, uniqueness: { scope: :ancestry, case_sensitive: true } in the location class, but another location type with the same name can still be created.

(#649 (comment))

I assume that's still true here.

[KatyTaylor]

@SHIV5T3R the change looks good.

A small thing; the README.md doesn't have any instruction on setting up bunny.yml file. I imagine one has to go to the workflow (in .github directory) to find out how to utilise it. When I was first setting it up, I ran to an error saying the bunny.yml was not found.

Do you think that we could improve the README.md to include instructions on the bunny.yml file?

I've done this in a separate PR :) #745

[dasunpubudumal]

@SHIV5T3R the change looks good.

A small thing; the README.md doesn't have any instruction on setting up bunny.yml file. I imagine one has to go to the workflow (in .github directory) to find out how to utilise it. When I was first setting it up, I ran to an error saying the bunny.yml was not found.

Do you think that we could improve the README.md to include instructions on the bunny.yml file?

Disregard this. Just saw Katy had updated the README. All good!