Preparing release 1.4.0 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release will change the underlying recommended library to https://www.nuget.org/packages/bblanchon.PDFium.Win32 as it is the only runtime up to date.
This was brought into my attention as multiple security issues are present in older builds (like https://www.nuget.org/packages/PdfiumViewer.Native.x86_64.v8-xfa/)
Changed the library loader so now it works cross-platform. However, the rendering and printing part still rely on System.Drawing.Common which works only on windows: [See here] (https://learn.microsoft.com/en-gb/dotnet/core/compatibility/core-libraries/6.0/system-drawing-common-windows-only)
Had to update some native bindings which were updated in the pdfium (e.g. FPDFDest_GetPageIndex => FPDFDest_GetDestPageIndex) + removed some older bindings which were not used anymore.
Because of the security issues, I also disabled the old loading part (e.g. FPDF_AddRef) => as I don't want to encourage any user to use vulnerable dependencies.