Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linters to deltametrics: flake8 #186

Merged

Conversation

mcflugen
Copy link
Collaborator

@mcflugen mcflugen commented Dec 13, 2024

Adds the flake8 linter to deltametrics and fixes some issues. For the most part, this is just removing unused imports and variables.

@mcflugen mcflugen force-pushed the mcflugen/add-flake8-linter branch from e04f347 to e445808 Compare December 13, 2024 17:47
@mcflugen mcflugen marked this pull request as draft December 13, 2024 17:50
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.35%. Comparing base (a429894) to head (e445808).
Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
deltametrics/plan.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #186      +/-   ##
===========================================
+ Coverage    89.33%   89.35%   +0.01%     
===========================================
  Files            9        9              
  Lines         3620     3617       -3     
===========================================
- Hits          3234     3232       -2     
+ Misses         386      385       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcflugen mcflugen marked this pull request as ready for review December 13, 2024 19:50
@mcflugen mcflugen merged commit 09a164d into sandpiper-toolchain:develop Dec 13, 2024
11 checks passed
@mcflugen mcflugen deleted the mcflugen/add-flake8-linter branch December 13, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant