Skip to content

Commit

Permalink
close issue #97 (#98)
Browse files Browse the repository at this point in the history
* close issue #97

replaces the 'selem' kwarg for the scikit-image binary closing method with the new
'footprint' argument. sets the minimum version for scikit-image to 0.19 in the
requirements.txt file which is the first version that has the 'footprint' argument.

* Update build.yml

update python versions in CI builds
  • Loading branch information
elbeejay authored Feb 25, 2022
1 parent 1f6b180 commit 8b8b04e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
python-version: [3.6, 3.7, 3.8]
python-version: [3.7, 3.8, 3.9]
env:
OS: ${{ matrix.os }}
PYTHON: ${{ matrix.python-version }}
Expand Down Expand Up @@ -48,10 +48,10 @@ jobs:
uses: actions/checkout@v2
with:
persist-credentials: false
- name: Set up Python 3.8
- name: Set up Python 3.9
uses: actions/setup-python@v2
with:
python-version: '3.8'
python-version: '3.9'
- name: Install dependencies
run: |
python -m pip install --upgrade pip
Expand Down
2 changes: 1 addition & 1 deletion deltametrics/plan.py
Original file line number Diff line number Diff line change
Expand Up @@ -1632,7 +1632,7 @@ def _custom_closing(img, disksize):
_iter = 0 # count number of closings, cap at 100
while (_changed != 0) and (_iter < 100):
_iter += 1
_newimg = morphology.binary_closing(img, selem=disk)
_newimg = morphology.binary_closing(img, footprint=disk)
_changed = np.sum(_newimg.astype(float)-img.astype(float))
_closed = _newimg
return _closed
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ scipy>=1.5
netCDF4
pyyaml>=5.1
Shapely
scikit-image
scikit-image>=0.19
xarray
pooch
numba
Expand Down

0 comments on commit 8b8b04e

Please sign in to comment.