Added export table w/ data to DAC. #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dac-table.js needs to be updated to agree with Alex's changes before merge. |
Mletter1
reviewed
Oct 14, 2024
Comment on lines
+361
to
+364
|
|
||
| # for tdms_type in metadata[0]["tdms_types"]: | ||
| # meta_column_names += ['Module ID/SN [' + tdms_type + ']'] | ||
|
|
There was a problem hiding this comment.
we could probably just delete this right?
There was a problem hiding this comment.
Yes, that would be fine.
|
@smartin71 I resolved the conflict with the changes I made due to SlickGrid upgrade and merged. Please test and make sure it didn't introduce any new bugs. I tried downloading selected rows and entire table and that worked. But checking "Export data with table. Note: this may result in a very large table." resulted in an alert that said "Can't export data -- inconsistent variable units." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change supports exporting data with the table, per customer request.