Alex min max #1127
Merged
Alex min max #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supports creating a reducer with our old vanilla Redux reducer and new Redux Toolkit reducers.
Cleaning up type definitions, constant name
…e always need both
Moving scatterplot selectors to scatterplot slice. Updating scatterplot slice to toggle visibility of grid, instead of setting it. Hiding grid when user unchecks show grid checkbox. Creating new React component for show grid checkbox.
|
I think there is still something wrong with this MR since its picking up changes that I think are already in Master |
|
Yeah looks weird, but I tested everything and it's all working. Thanks for the reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out there are no min / max issues, so this is just a little fix to address Redux state persistence.