Alex grid #1124
Merged
Alex grid #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supports creating a reducer with our old vanilla Redux reducer and new Redux Toolkit reducers.
Cleaning up type definitions, constant name
…e always need both
Moving scatterplot selectors to scatterplot slice. Updating scatterplot slice to toggle visibility of grid, instead of setting it. Hiding grid when user unchecks show grid checkbox. Creating new React component for show grid checkbox.
Mletter1
requested changes
Jun 20, 2023
web-server/plugins/slycat-parameter-image/js/Components/ScatterplotGrid.tsx
Outdated
Show resolved
Hide resolved
web-server/plugins/slycat-parameter-image/js/parameter-image-scatterplot.js
Outdated
Show resolved
Hide resolved
web-server/plugins/slycat-parameter-image/js/parameter-image-scatterplot.js
Outdated
Show resolved
Hide resolved
web-server/plugins/slycat-parameter-image/js/parameter-image-scatterplot.js
Outdated
Show resolved
Hide resolved
…x across all of them. Addresses #1124 Leaving colors array in d3 syntax since we feed it to d3 and I think it relies on that
|
Thanks for the suggestions @Mletter1 I implemented all of them. Let me know if you find anything else. |
|
np, I think thats it I'm gonna merge it |
Mletter1
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding option to display grid behind scatterplot in PS.