Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log Scale broken for variables with 0 or negative values #960

Open
alexsielicki opened this issue Jun 1, 2020 · 3 comments
Open

Log Scale broken for variables with 0 or negative values #960

alexsielicki opened this issue Jun 1, 2020 · 3 comments
Assignees
@alexsielicki
Labels
bug

Comments

@alexsielicki
Copy link
Collaborator

Seems that log scales can't contain 0 or smaller values. @pjcross, perhaps we should disable the log radio buttons for any variables that have 0 or smaller values in the Axes Scales UI?
@alexsielicki alexsielicki self-assigned this Jun 1, 2020
@pjcross
Copy link
Contributor

pjcross commented Jun 1, 2020

Yes, you can't take the log of zero or negative numbers. Yes, we should disable that choice for variables whose range includes values of zero or less.

@alexsielicki
Copy link
Collaborator Author

@pjcross thanks, I'll do that.

I will also need to update the validation for axes ranges to prevent 0 or negative values for variables that have a log scale. And update the disabling of log radio buttons each time the axes scales are changed.

@alexsielicki
Copy link
Collaborator Author

This is also affected by "Actions > Edit Variable Values" as the user can change the value of an editable variable to be 0 or less.

alexsielicki added a commit that referenced this issue Jul 15, 2024
@alexsielicki
fix: disable log scale radio button for variables with custom range m…
dbb569f 
…in of 0 or less. Addresses #960
alexsielicki added a commit that referenced this issue Jul 15, 2024
@alexsielicki
fix: enforce values greater than 0 when editing log scale variables. …
dd92d15 
…Addresses #960
Mletter1 pushed a commit that referenced this issue Jul 17, 2024
@alexsielicki
Add favicon (#1173)
19f48cc 
* feat: add favicon

* Adding favicon to all pages. Closes #1168

* style: minor typescript warning cleanup

* style: prettier

* style: prettier

* fix: disable log scale radio button for variables with custom range min of 0 or less. Addresses #960

* fix: enforce values greater than 0 when editing log scale variables. Addresses #960

* style: update validation text
alexsielicki added a commit that referenced this issue Jul 17, 2024
@alexsielicki
fix: adding validation for variable ranges for log scales. Addresses #…
6d5f97b 
…960
Mletter1 pushed a commit that referenced this issue Aug 7, 2024
@alexsielicki
Adding more validation for variable values on log scales (#1174)
e78fe6a 
* feat: add favicon

* Adding favicon to all pages. Closes #1168

* style: minor typescript warning cleanup

* style: prettier

* style: prettier

* fix: disable log scale radio button for variables with custom range min of 0 or less. Addresses #960

* fix: enforce values greater than 0 when editing log scale variables. Addresses #960

* style: update validation text

* fix: adding validation for variable ranges for log scales. Addresses #960

* refactor: remove test attribute and fix type

* build: fix vulnerabilities

* build: minor package upgrades

* refactor: rename old ControlsDropdown component

* refactor: move new ControlsBar into global components folder

* refactor: remove old ControlsDropdownOld and adjust new ControlsDropdown to handle all of its work

* refactor: rename component

* refactor: linting

* refactor: rename

* build: install types for bootstrap and uuid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexsielicki alexsielicki

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexsielicki @pjcross