Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic topology region file opening with group I/O #469
Dynamic topology region file opening with group I/O #469
Changes from 59 commits
da78685
a7a03e5
d152dbc
cbd37f5
f185aa3
eb5eb69
583760d
75e7dce
64c4280
796db44
e260195
cca436d
d15a9f8
adc1480
73f9874
c0ac995
59cdf25
89dfefb
dbb642f
778a564
5206a48
c0b290d
1026965
657b46a
ea75dd9
94a3d95
d963206
be88dca
cbaeaa2
5693dde
fc44446
7781505
f02f0f3
8ec59c9
9060aad
d4cfa71
deec345
936da1b
9a67af6
60f737a
1b5f4c8
ea2fe08
fdf2339
57dab19
ef1bdc6
07ae2a4
ff688ee
11a7abe
48af1ba
f6fc772
8fc2cc5
86a670b
5c1f1f0
c3d57f7
a5dc7bb
18afdd2
7f68c86
9157ee3
8b43583
075e6a8
71e3b0b
58f48b2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be the the same as
open_group("/")
? Probably OK to have it for convenience or maybe does something different?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I initially thought that this would be case when I originally implemented it that way. The problem is that if I am currently in a subgroup and I call
open_group("/")
, the file pointer that is returned fromex_get_group_id(get_file_pointer(), "/", &m_exodusFilePtr);
is exactly the file pointer returned from
get_file_pointer()
so that simply returns the same subgroup instead of the root groupThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I looked at the exodus function and it says that the root group is returned if name is passed in as NULL and not "/" although that should fall down to the full_ncid path and return the root also...
I've modified
ex_get_group_id
to check whether filename is NULL or "/" and should now return the correct root id. Will commit this fix soon.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, but are you still good with leaving this as a convenience function ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but maybe it just calls through to the other function... Or has much less in the guts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll wait for your commit to go through