Catalyst: Add Tag to Catalyst2 TPL + Cleaning #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Naapple
commented
Apr 1, 2024
Naapple
commented
- This change makes the Catalyst2 TPL point to a particular tag (v2.0.0) rather than master in the Kitware Catalyst repo. An extra argument needed to be added (CATALYST_WRAP_PYTHON) in the build of the TPL. All SEACAS ctests pass.
- Cleaned up our Catalyst API2 work following the suggestions made in our previous pull request: Catalyst API 2 IOSS Full Implementation Catalyst API 2 IOSS Full Implementation #431
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
gsjaardema
reviewed
Apr 1, 2024
| @@ -262,7 +262,7 @@ namespace Iocatalyst { | |||
| errmsg << "Catalyst pipeline is not a multi-input pipeline"; | |||
| IOSS_ERROR(errmsg); | |||
| } | |||
| auto name = p.catalystMultiInputPipelineName; | |||
| const auto name = p.catalystMultiInputPipelineName; | |||
There was a problem hiding this comment.
Could this be const auto &name
gsjaardema
reviewed
Apr 1, 2024
| @@ -280,7 +280,7 @@ namespace Iocatalyst { | |||
| errmsg << "Catalyst pipeline is not a multi-input pipeline"; | |||
| IOSS_ERROR(errmsg); | |||
| } | |||
| auto name = p.catalystMultiInputPipelineName; | |||
| const auto name = p.catalystMultiInputPipelineName; | |||
gsjaardema
reviewed
Apr 1, 2024
| @@ -262,7 +262,7 @@ namespace Iocatalyst { | |||
| errmsg << "Catalyst pipeline is not a multi-input pipeline"; | |||
| IOSS_ERROR(errmsg); | |||
| } | |||
| auto name = p.catalystMultiInputPipelineName; | |||
| const auto name = p.catalystMultiInputPipelineName; | |||
| for (auto cp : catPipes) { | |||
There was a problem hiding this comment.
Should this be auto &cp similar to line 284 or maybe even const auto &cp?
gsjaardema
approved these changes
Apr 1, 2024
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.