Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate use of reserved identifiers in SEACAS libraries and code #420

Merged
merged 6 commits into from
Nov 13, 2023

Conversation

gsjaardema
Copy link
Member

@gsjaardema gsjaardema commented Nov 10, 2023

Several uses of reserved identifiers are present in IOSS and Exodus libraries. These should be removed.

  • One of the first steps is to eliminate any of these functions that are in the public section of the class.
  • Change all uses of ex__abdc to some other convention. The ex__abdc are internal functions meant to used only in the library itself (although there are some uses in come C++ Internals classes such as Ioex::Internals)
  • Change all uses of the IOSS internal functions that end with double underscore to some other convention. (These are internal functions that are called by the thread-safe wrapper functions that hold a mutex. E.g my_function will hold a mutex and call my_function__

@gsjaardema gsjaardema changed the title IOSS: Move some functions using reserved ids to private Eliminate use of reserved identifiers in SEACAS libraries and code Nov 10, 2023
@gsjaardema gsjaardema self-assigned this Nov 10, 2023
@gsjaardema gsjaardema marked this pull request as draft November 10, 2023 15:48
@gsjaardema gsjaardema marked this pull request as ready for review November 10, 2023 22:58
@gsjaardema gsjaardema merged commit 523c9ad into master Nov 13, 2023
22 checks passed
@gsjaardema gsjaardema deleted the Remove_reserved_identifiers branch November 13, 2023 23:06
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant