Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how Albany gets trilinos, plus some cleaning #984

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

bartgol
Copy link
Collaborator

@bartgol bartgol commented Sep 25, 2023

Notably:

  • albany decides its own compilers, regardless of what trilinos used
  • find_package() must be called after project()
  • don't assume structure of trilinos install folder (if possible)
  • remove unused options

Fixes #982

- albany decides its own compilers, regardless of trilinos
- don't assume structure of trilinos install folder (if possible)
- remove unused options
@bartgol bartgol added Trilinos Stuff related to trilinos cmake bugfix labels Sep 25, 2023
@bartgol bartgol self-assigned this Sep 25, 2023
@mperego
Copy link
Collaborator

mperego commented Sep 25, 2023

Thanks @bartgol. Is this going to solve also the issues that Jim is seeing in E3SM? Note that E3SM is linking an old version of Albany.

@bartgol
Copy link
Collaborator Author

bartgol commented Sep 25, 2023

Thanks @bartgol. Is this going to solve also the issues that Jim is seeing in E3SM? Note that E3SM is linking an old version of Albany.

I don't think so. I need to re-do the installation of albany. It's not super long, but since he found a workaround, I don't think it's a priority.

@bartgol
Copy link
Collaborator Author

bartgol commented Sep 26, 2023

This works on my workstation. Merging, according to discussion in today's telecon.

@ikalash We'll need to revert the hack of setting GNUInstallDirs. At the telecon we were suggesting to roll back a couple, to make sure we're still getting coverage if this fix ends up not working as expected. How do you want to handle? I can simply revert the commits you did for the dashboards, if you think that's ok.

@bartgol bartgol merged commit d351216 into master Sep 26, 2023
@bartgol bartgol deleted the bartgol/fix-find-package-trilinos branch September 26, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix cmake Trilinos Stuff related to trilinos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing Albany configures due to incorrect Trilinos version
2 participants