Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using globs in CMakeLists #87

Closed
ibaned opened this issue Mar 20, 2017 · 3 comments
Closed

Stop using globs in CMakeLists #87

ibaned opened this issue Mar 20, 2017 · 3 comments
Assignees

Comments

@ibaned
Copy link
Contributor

ibaned commented Mar 20, 2017

see the NOTE in the CMake documentation, replicated here:

Note: We do not recommend using GLOB to collect a list of source files from your source tree. If no CMakeLists.txt file changes when a source is added or removed then the generated build system cannot know when to ask CMake to regenerate.

This recently affected Trilinos when a new header file was added. As a best practice, we should replace any use of globs in Albany with explicit lists of files.

@jtostie
Copy link
Contributor

jtostie commented Mar 31, 2017

I am responsible for some of this in LCM (maybe that's the only place it happens, I don't know). I get the point that the CMake documentation is making. For historical context, my motivation was usability and efficiency, as the Albany configuration step was easier and cheaper than having to touch the CMake files.

I wold not be opposed if someone removed the GLOBs.

@ibaned ibaned self-assigned this Mar 31, 2017
ibaned added a commit that referenced this issue Apr 3, 2017
ibaned added a commit that referenced this issue Apr 4, 2017
ibaned added a commit that referenced this issue Apr 4, 2017
ibaned added a commit that referenced this issue Apr 4, 2017
ibaned added a commit that referenced this issue Apr 12, 2017
@ibaned
Copy link
Contributor Author

ibaned commented Apr 12, 2017

done with this for now.

@ibaned ibaned closed this as completed Apr 12, 2017
@ibaned
Copy link
Contributor Author

ibaned commented Aug 28, 2017

By the way, I just found out Tpetra has a really funny way of dealing with this:

https://github.com/mhoemmen/Trilinos/blob/e65e32851308f68158928cfc2bd8e0518df379a4/packages/tpetra/core/src/CMakeLists.txt#L368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants