Skip to content
This repository has been archived by the owner on Jan 24, 2020. It is now read-only.

suggest to split client according to language #5

Open
thinkerou opened this issue Sep 12, 2018 · 7 comments
Open

suggest to split client according to language #5

thinkerou opened this issue Sep 12, 2018 · 7 comments

Comments

@thinkerou
Copy link

Hi, @celrenheit suggestion, sandglass/sandglass-client splits to sandglass/sandglass-go, sandglass/sandglass-node, sandglass/sandglass-java, sandglass/sandglass-dart, and so on.
it have shorter path/package-name and convenient to auto test. thanks!

@celrenheit
Copy link
Member

Hi,
I entended to split them. I'll try to do it whenever I have some time.

@thinkerou
Copy link
Author

Hi @celrenheit sandglass-grpc have also suggestion, thanks your work!

@ghost
Copy link

ghost commented Sep 12, 2018

Watching for this to be done first before I build a dart client.

@c1tt1
Copy link

c1tt1 commented Sep 20, 2018

@gedw99 I could help you with the dart client if needed, I built the node client and currently working on the python client

@c1tt1
Copy link

c1tt1 commented Sep 20, 2018

I am currently building the python client, and get this error.

  File "/Users/apple/sandglass-client/python_/sandglass_pb2_grpc.py", line 4, in <module>
    import sandglass_pb2 as sandglass__pb2
  File "/Users/apple/sandglass-client/python_/sandglass_pb2.py", line 20, in <module>
    from github.aaakk.us.kg.gogo.protobuf.gogoproto import gogo_pb2 as github_dot_com_dot_gogo_dot_protobuf_dot_gogoproto_dot_gogo__pb2

Can anyone help me here. The grpcio docs gives very little about this.

@ghost
Copy link

ghost commented Sep 20, 2018 via email

@c1tt1
Copy link

c1tt1 commented Sep 20, 2018

@gedw99 Thanks, and sure let me know whenever you upload it, we might have time differences but that's fine. I like that you pointed out examples and "tests" especially, as I also need to test the node client, the only slight problem is sandglass isn't stable yet and might be redundant writing tests for now. The python client as you can see is nearly implemented.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants