DMET Effective Core Potential fix(related to #306) #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesB-1qbit
requested review from
ValentinS4t1qbit and
alexfleury-sb
as code owners
|
In a nutshell: I think this is great work, I think this addresses Joshua's issue. The messaging in the PR however needs improvement. Could we have something a bit more descriptive for the title and desc of the PR ? That does not describe what this PR actually does / change. Forget about Joshua's issue for a second: why are you pushing this code? What feature have you fixed ? Added ? Improved ? "Potential fix" is not great wording. The bar here is higher and clearer: when running Joshua's use case verbatim, what do we observe ? This is either a fix, or a step in the right direction (which is already enough for a PR). It seems to me that your test is basically Joshua's use case (which is awesome !), so at this point you should be able to proclaim whether or not this is the fix that does it, or if something else still is wrong. When I read both your test and his prints, it seems that you have effectively reconciled the results far beyond chemical accuracy between CCSD and DMET-CCSD no fragmentation. This feels like clear victory, in this context. This does fix things for the use case, no? Probably once this is merged, we can tell Joshua his use case was added as a test and ask him to pull and rerun. |
ValentinS4t1qbit
approved these changes
Jun 22, 2023
ValentinS4t1qbit
changed the title
ValentinS4t1qbit
added a commit
that referenced
this pull request
Jun 29, 2023
* Update develop to catch up with main version 0.3.3 (#249) * Fix link of fig in qchem & excited states notebook (#250) * allow single flip index dis for qcc (#247) * allow single flip index dis for jkmn * Richardson extrapolation: bug fix + error estimation (#252) * Bugfix: DMET with QCC (#253) * iQCC using only Clifford circuits notebook (#254) * pUCCD ansatz (#251) * UHF reference (#240) * uhf implementation with VQESolver functionality * support for all types of orbital freezing * add active_spin and uhf attributes to SecondQuantizedDMETFragment * add spin to adapt_ansatz arguments * added multi-product, grid_circuits and discrete_clock (#257) * added multi-product, grid_circuits and discrete_clock * translation to pennylane (#260) * tangelo to pennylane format translation Co-authored-by: Valentin Senicourt <[email protected]> * bump testing version to 3.8 (#262) Updating python version to 3.8 in automated tests, as 3.7 is no longer maintained by the Python dev team * Auto threshold cutoff for small coefficients in LCU (#261) * check for small value lcu * changed to keep same vector length but apply no operations * Openshell DMET (#208) * Open-shell DMET. * Fix for get_rdm CCSD. * Added NAO localization. * Added LiO2 spin=1 DMET test. * Added UHF MF for DMET. New get_rdm for VQESolver. * Save mid-circuit measurement (#256) * A flag now allows users to save mid-circuit measurements for each shot run. Co-authored-by: Valentin Senicourt <[email protected]> * Fix for IBMQConnection (#264) * Updated copyright year to 2023 (#267) * added draw method to circuit (#266) * added draw method to circuit (warning about font comes up in linux env) * Cirq, qulacs, pennylane and projectq operator translation functions (#268) * Support to bidirectional translation of operators for cirq, qulacs, PennyLane, projectq. * Fixed a bug in QulacsSimulator.expectation_value_from_prepared_state. * Important bug in qiskit -> tangelo op translation fixed * Fixed identity operator evaluation and extended the accepted input types in compute_rdms (#269) * Compute RDMs function can now hangle both term formats (string and openfermion tuple). * Unhashable list for of -> conversion to tuples. * Handling all the inputs in compute_rdms. * Temporarily disabling OS-DMET (#271) * Temporarily disabling for code verification purpose, as the implementation seems to return very odd and incorrect results for simple systems. * Link to new example repo * Update README.rst * Revert changes that broke tests (#275) * reverted changes that broke tests * DMET + frozen orbitals for each fragment (#276) * DMET + frozen orbitals, added DMET/frozen tests. * Example folder relocated to new repo Tangelo-Examples (#274) * removed examples folder, removed notebooks from automated tests, added link higher in README.rst * Docs update (#272) * Updated conf.py, tested building docs and fixed comments/docs. * Removed tutorials.rst with the notebooks. * Desired measurement result (#263) * New feature: return frequencies matching desired mid-circuit measurement values. --------- Co-authored-by: James Brown <[email protected]> * fix error for imaginary qubit_op with desired meas result (#278) * Integrate bug fix into main before release (#278) (#279) (#280) Co-authored-by: James Brown <[email protected]> * fix error for imaginary qubit_op with desired meas result (#278) * Depth function performance increase (#285) * Depth function takes now less than half a second to compute it from scratch for ~120K depth circuit. * Fix for (inverse of S and T gate) #287. (#288) * Translation perf tests (operator, circuit) (#289) * Performance test for translation layer of linq, for most formats --------- Co-authored-by: Valentin Senicourt <[email protected]> Co-authored-by: ValentinS4t1qbit <[email protected]> * deterministic desired_meas_result (#290) * deterministic desired_meas_result * Mifnohelper print: remove problem handle (#293) * Removed problem handle from print. It now only focuses on chemistry information Co-authored-by: Valentin Senicourt <[email protected]> Co-authored-by: ValentinS4t1qbit <[email protected]> * Combinatorial mapping of fermionic Hamiltonians (#286) * Initial implementation. Known performance scaling issues, may attempt to introduce a different QubitOperator in the future. * Re-enabling open-shell DMET (#291) * Re-enabling OS-DMET. * Support for symbolic simulator (simpy) (#292) Support for symbolic backend based on sympy, to provide algebraic expressions for states / circuits with less than 10 qubits. Notebook / examples to follow later on. * Arg simulate_options and projective_circuit to VQESolver (#298) * It is now possible to request desired measurements and other options for the "simulate" method called by the backend * Projective circuits can be used with VQE algorithm(s). Either passed by the user explicitly or integrated through the ansatz. --------- Co-authored-by: Valentin Senicourt <[email protected]> * Supporting symbols as parameters and add nsimplify to results (#300) * Symbolic expression simplified. * Simplification of exp. value and fixed a bug in translate op. * Add ability to get inverse with Symbol parameters. * Switch nsimplify to evalf. * Trim trivial qubits from circuit and Hamiltonian (#302) Remove qubits that are in a deterministic state in quantum circuits, and simplify qubit Hamiltonian accordingly, in order to reduce resource requirements while computing expectation values. --------- Co-authored-by: Valentin Senicourt <[email protected]> * Push contributors towards develop and not to main for PRs (#303) * Update to CONTRIB (main -> develop) and added workflow to help avoid PR to main that are not from develop * Set the DMET virtual orbital truncation threshold at the user level (#304) * Add option to turn off virt. orb. truncation. * Changed the threshold instead of a flag. Occ. set to their abs values. * Trim bug (#305) * minor bug fixes + test * Added typing for option dictionaries in quantum agorithms (#307) * added typing for option dictionaries, which improves user experience (autocomplete, auto-loading of docstrings for different GUIs) and handle options better overall * IntegralSolver class: base + support for Psi4 (#297) * Tests for pyscf, test for psi4, tests for custom IntegralSolver * temporary: install NO_PYSCF available to users * new: MP2Solver This PR will be followed by 1-2 other PRs to decouple pyscf from almost all algorithms and streamline the use of classical chem backends (support for all classical solvers, turning pyscf as an optional dependency for Tangelo, fixing docs and README etc as a result) * Change multi-controlled CNOT to multi-controlled CX (#308) * change multi-controlled CNOT to multi-controlled CX --------- Co-authored-by: Valentin Senicourt <[email protected]> * Braket connection (#312) Support for Braket connection, including batch submission of jobs. Tests, docs, refresh of env_var.sh A PR for the QPU notebook will follow --------- Co-authored-by: Valentin Senicourt <[email protected]> Co-authored-by: ValentinS4t1qbit <[email protected]> * Support for UMP2 initial parameters (#310) * Support for UMP2 initial parameters. * Checkfile for IntegralSolverPySCF (#311) * chkfile for IntegralSolverPySCF. * QubitOperator import from Tangelo, for better encapsulation (#299) * Use Tangelo's `QubitOperator` instead of OpenFermion when possible. * Constructor method `from_openfermion` and export method `to_openfermion` available in `QubitOperator` class. Remaining usage of Openfermion is tied to qubit mappings mostly, and code relying on other Openfermion features. --------- Co-authored-by: Valentin Senicourt <[email protected]> Co-authored-by: ValentinS4t1qbit <[email protected]> * FCISolverPsi4 (#309) * moved chem tests to molecular_computation tests * Changed FCISolver to class with solver attribute --------- Co-authored-by: Valentin Senicourt <[email protected]> * Removed deprecated Linq functions (#316) * Removed deprecated versions of trasnlation functions and Simulator. --------- Co-authored-by: Valentin Senicourt <[email protected]> Co-authored-by: ValentinS4t1qbit <[email protected]> * CCSD solver psi4 (#313) * add ccsd_solver test to psi4 testing * get_rdm currently not supported, suggestions added in comments * ADAPT: add spin to available options (#317) * add spin to available options and docstring * MP2 psi4 (#315) * Support for MP2 with psi4 backend. * get_rdm and get_mp2_parameters currently unsupported, suggestions left in docstrings. * skip performance tests (Linq) in pytest (#319) Perrformance tests take time and should not be run systematically * Typos in docs (#321) * Added spaces in messages. * Typos and code format. * Add period. * DMET Effective Core Potential fix(related to #306) (#318) * potential fix for #306, test added * Change installation (#320) * remove no_pyscf, attempt windows test * updated psi4 test --------- Co-authored-by: Valentin Senicourt <[email protected]> * DMET-ecp test fix: change optimizer to minimize square (#323) * improved Error message for MP2 initialization in UCCSD (pySCf currently required) (#322) * improved Error message for MP2 initialization if pyscf is not found * Qiskit-related: deprecation update to SparsePauliOp and bug workaround (#325) * Stim clifford simulator integration (#314) * direct tableau * noise and circuit sampler * decomposition into clifford gates * clifford decomp tests, and SDAG in cirq * is_clifford in gate class * expand clifford decomp to integer values * small comments, add pip install stim to workflow Co-authored-by: Valentin Senicourt <[email protected]> * Bumping Tangelo version number in _version.py * Update CHANGELOG.md --------- Co-authored-by: Valentin Senicourt <[email protected]> Co-authored-by: AlexandreF-1qbit <[email protected]> Co-authored-by: James Brown <[email protected]> Co-authored-by: KrzysztofB-1qbit <[email protected]> Co-authored-by: Valentin Senicourt <[email protected]> Co-authored-by: James Brown <[email protected]> Co-authored-by: ValentinS4t1qbit <[email protected]> Co-authored-by: elloyd-1qbit <[email protected]> Co-authored-by: GitHub Actions <[email protected]>
ValentinS4t1qbit
added a commit
that referenced
this pull request
Sep 20, 2023
Co-authored-by: Valentin Senicourt <[email protected]> * Supporting symbols as parameters and add nsimplify to results (#300) * Symbolic expression simplified. * Simplification of exp. value and fixed a bug in translate op. * Add ability to get inverse with Symbol parameters. * Switch nsimplify to evalf. * Trim trivial qubits from circuit and Hamiltonian (#302) Remove qubits that are in a deterministic state in quantum circuits, and simplify qubit Hamiltonian accordingly, in order to reduce resource requirements while computing expectation values. --------- Co-authored-by: Valentin Senicourt <[email protected]> * Push contributors towards develop and not to main for PRs (#303) * Update to CONTRIB (main -> develop) and added workflow to help avoid PR to main that are not from develop * Set the DMET virtual orbital truncation threshold at the user level (#304) * Add option to turn off virt. orb. truncation. * Changed the threshold instead of a flag. Occ. set to their abs values. * Trim bug (#305) * minor bug fixes + test * Added typing for option dictionaries in quantum agorithms (#307) * added typing for option dictionaries, which improves user experience (autocomplete, auto-loading of docstrings for different GUIs) and handle options better overall * IntegralSolver class: base + support for Psi4 (#297) * Tests for pyscf, test for psi4, tests for custom IntegralSolver * temporary: install NO_PYSCF available to users * new: MP2Solver This PR will be followed by 1-2 other PRs to decouple pyscf from almost all algorithms and streamline the use of classical chem backends (support for all classical solvers, turning pyscf as an optional dependency for Tangelo, fixing docs and README etc as a result) * Change multi-controlled CNOT to multi-controlled CX (#308) * change multi-controlled CNOT to multi-controlled CX --------- Co-authored-by: Valentin Senicourt <[email protected]> * Braket connection (#312) Support for Braket connection, including batch submission of jobs. Tests, docs, refresh of env_var.sh A PR for the QPU notebook will follow --------- Co-authored-by: Valentin Senicourt <[email protected]> Co-authored-by: ValentinS4t1qbit <[email protected]> * Support for UMP2 initial parameters (#310) * Support for UMP2 initial parameters. * Checkfile for IntegralSolverPySCF (#311) * chkfile for IntegralSolverPySCF. * QubitOperator import from Tangelo, for better encapsulation (#299) * Use Tangelo's `QubitOperator` instead of OpenFermion when possible. * Constructor method `from_openfermion` and export method `to_openfermion` available in `QubitOperator` class. Remaining usage of Openfermion is tied to qubit mappings mostly, and code relying on other Openfermion features. --------- Co-authored-by: Valentin Senicourt <[email protected]> Co-authored-by: ValentinS4t1qbit <[email protected]> * FCISolverPsi4 (#309) * moved chem tests to molecular_computation tests * Changed FCISolver to class with solver attribute --------- Co-authored-by: Valentin Senicourt <[email protected]> * Removed deprecated Linq functions (#316) * Removed deprecated versions of trasnlation functions and Simulator. --------- Co-authored-by: Valentin Senicourt <[email protected]> Co-authored-by: ValentinS4t1qbit <[email protected]> * CCSD solver psi4 (#313) * add ccsd_solver test to psi4 testing * get_rdm currently not supported, suggestions added in comments * ADAPT: add spin to available options (#317) * add spin to available options and docstring * MP2 psi4 (#315) * Support for MP2 with psi4 backend. * get_rdm and get_mp2_parameters currently unsupported, suggestions left in docstrings. * skip performance tests (Linq) in pytest (#319) Perrformance tests take time and should not be run systematically * Typos in docs (#321) * Added spaces in messages. * Typos and code format. * Add period. * DMET Effective Core Potential fix(related to #306) (#318) * potential fix for #306, test added * Change installation (#320) * remove no_pyscf, attempt windows test * updated psi4 test --------- Co-authored-by: Valentin Senicourt <[email protected]> * DMET-ecp test fix: change optimizer to minimize square (#323) * improved Error message for MP2 initialization in UCCSD (pySCf currently required) (#322) * improved Error message for MP2 initialization if pyscf is not found * Qiskit-related: deprecation update to SparsePauliOp and bug workaround (#325) * Stim clifford simulator integration (#314) * direct tableau * noise and circuit sampler * decomposition into clifford gates * clifford decomp tests, and SDAG in cirq * is_clifford in gate class * expand clifford decomp to integer values * small comments, add pip install stim to workflow Co-authored-by: Valentin Senicourt <[email protected]> * Bump develop to v0.4.0.RC (#327) * Update _version.py * Fixed requirements (#324) * Remove pre-install reqs (wheel) * Remove openfermionpyscf as not needed anymore * Us extra_requires for pyscf optional dependencies. * Removed unused imports * Use long description for long description * Fix combinatorial mapping when spin!=0. (#330) * QPESolver implementation (#332) * fix qiskit-aer installation * Initial QPE framework: vanilla QPE with built-in or user-defined unitary * Fixes to MIFNOHelper after QEMIST Cloud 0.6.0 release (#331) * Fixes to keep up with the update of QEMIST Cloud * Adding more python versions to tests (#333) * adding more python versions to tests, per-version artifacts files, ensuring all of them fully run regarding of failure --------- Co-authored-by: ValentinS4t1qbit <[email protected]> * Bug Fix: n_shots parameter was ignored in get_expectation_value (#337) * add missed condition in get_expectation_value * added test relying on std_dev * convert all gate names to upper case and check that it is a string (#340) * Fixes for new version of qiskit runtime. Tangelo now supports sampler with several circuits (#341) Co-authored-by: ValentinS4t1qbit <[email protected]> * Function that returns the qubits used for Truncated Taylor Series (#339) * added function that returns the qubits used for truncated taylor series * removed spurious arg in docstring * Support for following VQE minimization in VQESolver (#342) * HiddenPrints with verbose option. Option to save energies at each opt steps. * Variable for number of steps. * Align things. * Readme update: more straight to the point. (#343) --------- Co-authored-by: AlexandreF-1qbit <[email protected]> Co-authored-by: James Brown <[email protected]> Co-authored-by: KrzysztofB-1qbit <[email protected]> Co-authored-by: Valentin Senicourt <[email protected]> Co-authored-by: James Brown <[email protected]> Co-authored-by: ValentinS4t1qbit <[email protected]> Co-authored-by: elloyd-1qbit <[email protected]> Co-authored-by: Charles Coulombe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #306
Previously the Effective Core Potential term was not added to the fragment Fock matrix for RHF systems in DMETProblemDecomposition. This PR addresses that issue and adds a test to show that it is correctly returning the expected answer as described in #306.