Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tests #21

Merged
merged 2 commits into from
Jun 18, 2016
Merged

Refactor tests #21

merged 2 commits into from
Jun 18, 2016

Conversation

mackermans
Copy link
Collaborator

@mackermans mackermans commented Jun 18, 2016 •
edited
Loading

Making tests more consistent and clear

@davesnx
Copy link
Member

davesnx commented Jun 18, 2016 •
edited
Loading

Cool, thats ofc necesary.

But I want to push to add the dependency of requireDir and put proper names on the file system, instead of 1.json, 1.js call it directly PATH_JSON_FIXTURE

That sounds good to you?
I will merge this and can clean it a little bit later.

@mackermans mackermans merged commit 7d82715 into master Jun 18, 2016
@mackermans mackermans deleted the Refactor_tests branch June 18, 2016 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mackermans @davesnx