Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Returns nil when #id_to_uri is passed empty strings. #960

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Returns nil when #id_to_uri is passed empty strings. #960

merged 1 commit into from
Aug 14, 2024

Conversation

bwatson78
Copy link
Contributor

  • lib/valkyrie/persistence/fedora/metadata_adapter.rb: stops sending empty string values to #pair_path and associated errors.
  • spec/valkyrie/persistence/fedora/metadata_adapter_spec.rb: tests the added protective return of nil.

@bwatson78 bwatson78 added the bug label Aug 14, 2024
@bwatson78 bwatson78 self-assigned this Aug 14, 2024
@tpendragon tpendragon merged commit 6508c08 into main Aug 14, 2024
13 checks passed
@tpendragon tpendragon deleted the returns_nil_if_empty_string_id_to_uri branch August 14, 2024 21:41
@bwatson78 bwatson78 mentioned this pull request Aug 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpendragon tpendragon tpendragon approved these changes

@dlpierce dlpierce Awaiting requested review from dlpierce

@randalldfloyd randalldfloyd Awaiting requested review from randalldfloyd

Assignees

@bwatson78 bwatson78

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bwatson78 @tpendragon