fix failure to forward to collection edit after create for PcdmCollection #5283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a collection is created with
Hyrax.config.collection_model = 'Hyrax::PcdmCollection'
, the page does not forward to the collection edit page after saving the new collection.Cause
The
valkyrie_create
method did not callafter_create
. Theafter_create
method is what performed the forward to the edit page.Solution
Update
valkyrie_create
to callafter_create
if saving is successful. Theafter_create
method was also updated to perform some steps only when@collection.is_a? ActiveFedora::Base
because those steps were already performed byvalkyrie_create
.@samvera/hyrax-code-reviewers