Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The valkyrie_create! method was passing the original admin_set to
Hyrax::Collections::PermissionsCreateService.create_default
. This works for ActiveFedora because it updates the original admin_set during save. For valkyrie, the original admin_set does not have a value for id after it is persisted. It needs to pass the results ofHyrax.persister.save
which is the updated admin_set that does have a value for id.Expected
Create the new admin set and associated permission template without errors.
Actual
Creates the new admin set, but gets an error when creating the permission template.
To reproduce:
Run the following test with the first commit that adds the test, but not the fix.
@samvera/hyrax-code-reviewers