map SolrDocument#collection? to configured class #5214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
force-pushed
the
collection-solr-doc
branch
3 times, most recently
from
85444e6 to
9025ea1
Compare
using `#collection?` on the `hydra_model` turns out to be useless, since `hydra_model` is actually a Class, not a model instance. instead just respect whatever model is configured. trust that `SolrDocument#hydra_model` will get resolved to the configured class.
no-reply
pushed a commit
that referenced
this pull request
Oct 22, 2021
the tests for this controller were not sufficiently granular to make debugging easy. i encountered this working on Collection support for Valkyrie (where these tests are failing seemingly due to #5214). it took me some time to understand what was going wrong, so i wanted to make the tests clearer by following the one-expectation-per-spec-block pattern.
no-reply
pushed a commit
that referenced
this pull request
Oct 22, 2021
the tests for this controller were not sufficiently granular to make debugging easy. i encountered this working on Collection support for Valkyrie (where these tests are failing seemingly due to #5214). it took me some time to understand what was going wrong, so i wanted to make the tests clearer by following the one-expectation-per-spec-block pattern.
elrayle
approved these changes
Oct 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using
#collection?on thehydra_modelturns out to be useless, sincehydra_modelis actually a Class, not a model instance.instead just respect whatever model is configured. trust that
SolrDocument#hydra_modelwill get resolved to the configured class.@samvera/hyrax-code-reviewers