Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I117 pals vs pals knapsack comp #2441

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Conversation

kirkkwang
Copy link
Collaborator

Contributing back any changes from PALNI-PALCI repo from April to now.

@kirkkwang kirkkwang added the patch-ver for release notes label Jan 31, 2025
Copy link

github-actions bot commented Jan 31, 2025

Test Results

    3 files  ±0      3 suites  ±0   17m 31s ⏱️ -2s
2 057 tests ±0  2 001 ✅ ±0  56 💤 ±0  0 ❌ ±0 
2 084 runs  ±0  2 026 ✅ ±0  58 💤 ±0  0 ❌ ±0 

Results for commit 10394ec. ± Comparison against base commit e35ce71.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy c2cb68f6-db20-4a94-a9eb-70dfefdd6be9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit d6dee520-bc2c-4ddd-90d6-cc5d42fcfae4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 754f0a79-9f1a-49d6-8fcc-5beee375d756
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update bd738ee0-110b-4370-9d1c-e94013631e94
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 5696d96c-def3-41e3-b2d7-3a3412139e46
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 0ec737da-41ef-4ccd-99b4-6fc0abf0c3f7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read f4be359f-ce1f-4d90-861c-c9ce2ce97ec7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update e85da48c-cd59-4b36-9dac-c2eaaa62fe41
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 16ff4416-fd0d-4b7d-b879-aa533806efdd
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit d1bae897-7170-4fde-af94-2e8b734be3b5
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 4e2824f8-dd7c-4aa5-b56b-ded4eb5bed42
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 12dd3f3d-44f7-4156-a73a-86ae3435436d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read eeceec43-707d-46d6-b41f-01c74c497d1d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 564df63a-8924-4978-a548-c745e957e288
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 377a3f0f-b501-4ac4-bea8-d44b65333dca
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 98f1458c-3dd3-4b47-8bbf-981246a86fb1
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read db6bf552-45ac-4059-b79f-d47d945671fd
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update dfad03d2-5381-4bb6-8b44-5d1f3d490c69
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy cef5b933-c7a3-4a9d-9f80-be0d907a0fe4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 0f75f6e2-0a05-4fd0-8c43-966051ca43ee
…

♻️ This comment has been updated with latest results.

laritakr
laritakr previously approved these changes Jan 31, 2025
This commit will remove the commented out logic for the
csv_parser_decorator since it was not being used.  It seems the missing
fields check is working fine in Bulkrax so we'll use that.
@kirkkwang kirkkwang merged commit b9f5d43 into main Jan 31, 2025
8 checks passed
@kirkkwang kirkkwang deleted the i117-pals-vs-pals-knapsack-comp branch January 31, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants