Modify Collection & Admin Set Valkyrization #2157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 26, 2024 18:30
Remove decorating of PdcmCollection and generate a CollectionResource. Address some inconsistent behavior between Collection & CollectionResource. Temporarily address bulkrax_identifier inconsistencies, to be moved into Bulkrax at a later point. These came in via some contribute-back work.
Creates Hyku's version of Hyrax's Hyrax::AdministrativeSet rather than using the decorator pattern.
With the addition of CollectionResource and AdminSetResource, these configurations need to change.
jeremyf
approved these changes
Jan 29, 2024
The catalog controller, when used in the shared tenant, wouldn't return the url to the work in the appropriate tenant without this generated url. With Valkyrie, additional logic is needed to handle resources and legacy models consistently.
|
Replaced by #2164 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses:
Moves away from directly using Hyrax::PcdmCollection and Hyrax::AdministrativeSet instead favoring inheriting from those (with CollectionResource and AdminSetResource). This allows for inheriting from Hyrax factories and extending them; thus bringing Hyku’s testing ecosystem closer to Hyrax.
Similar work may be desired for FileSets, but this would require some base Hyrax work first.
Note: There is javascript in app.js.erb that may affect the behavior of granting of permissions in the UI... this still needs to be investigated.