Various Features from Adventist #2046
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
orangewolf
commented
Dec 12, 2023
•
orangewolf
commented
- adding blacklight advanced search
- adding order already to allow ordered ActiveFedora fields
- order creators in collections, generic works, images
- adding good_job as a configuratble alternative to sidekiq
- bump bulkrax to 5.4
- ability to restore defaults in the admin color selectors
- increase the default sorting field set on searches
- expanded knapsack support
- override yaml files
- new app title
- override devise parameters
- use iiif_print to enable UV metadata search
- utilize blacklight saved search and search history
- add additional color selectors for the home page about section
- adjust thumbnail path settings to make overriding them easier
- use a more human readable label for each page in the iiif manifest
jeremyf
reviewed
Dec 21, 2023
| # :add_advanced_parse_q_to_solr, :add_advanced_search_to_solr filters. Those existed in their | ||
| # current position and at the end of the array. | ||
| # | ||
| # When we had those duplicates, the :add_advanced_parse_q_to_solr obliterated the join logic |
There was a problem hiding this comment.
@orangewolf I'm drawing attention to this particular add. The breadcrumbs are almost adequate and I think what I'm seeing in test on Hyrax 5 Upgrade will be ok. But this is a subtle bug and we're about to go on break so I'm trying to make sure to provide insight/guidance for possible troubleshooting.
There was a problem hiding this comment.
I updated in the Hyrax 5 upgrade: 1929072
It may be alright to back port. We'll know when we enter into more testing/QA on that branch.
|
verify that all these are included in hyrax-5-upgrade. delete with hyrax-5-upgrade is merged into main |
ShanaLMoore
force-pushed
the
adventist_dev
branch
from
88de036 to
6b6d186
Compare
ShanaLMoore
force-pushed
the
adventist_dev
branch
from
6b6d186 to
9fac5f9
Compare
added 3 commits
February 14, 2024 14:39
This reverts commit 324122b.
Setting HYKU_GEONAMES_USERNAME doesn't work per the README's instruction without this change. The username is also configurable per tenant. This commit includes instructions to clarify such with the user.
ShanaLMoore
force-pushed
the
adventist_dev
branch
from
ef7a36c to
fce8374
Compare
Reverting this changes because I didn't notice the metaprogramming happening in the #settings method. The geonames_username is correctly getting set when using an ENV var, for new accounts. Pre-existing accounts must configure their tenant's settings from the proprietor dashboard.
This reverts commit 98007b8.
This reverts commit 195661a.
This is required to render PDF.js TODO - update adventist_knapsack after this gets merged into adventist_dev Issue: - https://github.com/scientist-softserv/adventist-dl/issues/748
We needed to move everything into a web subdirectory of PDF.js for the app to find files. Related Issues: - https://github.com/scientist-softserv/adventist-dl/issues/748 - https://github.com/scientist-softserv/adventist-dl/issues/746
Add pdf.js directory to repo
ShanaLMoore
reviewed
Apr 24, 2024
| @@ -56,6 +56,10 @@ | |||
| # Use a different cache store in production. | |||
| # config.cache_store = :mem_cache_store | |||
|
|
|||
| if ENV.fetch('RAILS_CACHE_STORE_URL', '').match(/^redis/) | |||
There was a problem hiding this comment.
should this be contributed back to main too? @orangewolf
|
outdated + we've already contributed back adv |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.