🐛 [I951] false object import bug #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 19, 2024 16:30
Imports were failing for active fedora applications because ordered_memebers is an undefined method for FalseClass. object gets assigned by #find, which intentionally returns false for new objects; we can't find something that doesn't exist. Issue: - #951
ContentUpdateEventJob would fail and retry over and over again. This is because we were passing it a nil user. Similar issue (previously fixed): - #656
ShanaLMoore
commented
Apr 20, 2024
| @@ -119,7 +121,7 @@ def import_files_filenames | |||
| def destroy_existing_files | |||
| return unless object.present? && object.file_sets.present? | |||
| object.file_sets.each do |fs| | |||
| Hyrax::Actors::FileSetActor.new(fs, @user).destroy | |||
| Hyrax::Actors::FileSetActor.new(fs, user).destroy | |||
There was a problem hiding this comment.
This fixes the issue seen in the screenshot. see: user
|
I've tested this branch in combination with our app which is currently built on Hyrax 3.6.0 (branch here) using a Bulkrax CSV importer as attached. This successfully imported whereas with Bulkrax 8.0.0 we were getting the stack trace shown in #951 Unfortunately I'm not familiar enough with the bulkrax code to be able to comment on the code changes, but I'm happy that they work. Thank you @ShanaLMoore ! |
kirkkwang
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ActiveFedora based applications were unable to import works when they upgraded to v8.0.0 (the first Bulkrax version that supports valkyrie)
Issue:
BEFORE
AFTER (successful import + re running of the importer)
Sample testing files
af-embargo-test.zip