Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix #work_identifier_search_field logic #891

Merged
merged 2 commits into from
Dec 11, 2023
Merged

🐛 Fix #work_identifier_search_field logic #891

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee5d878
🐛 Fix #work_identifier_search_field logic
jeremyf Dec 11, 2023
90cbae3
🧹 Appease rubocop
jeremyf Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/parsers/bulkrax/application_parser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def work_identifier
# defaults to work_identifier value + "_sim"
# @see #work_identifier
def work_identifier_search_field
@work_identifier_search_field ||= get_field_mapping_hash_for('source_identifier')&.values&.first&.[]('search_field')&.first&.to_s || "#{work_identifier}_sim"
@work_identifier_search_field ||= Array.wrap(get_field_mapping_hash_for('source_identifier')&.values&.first&.[]('search_field'))&.first&.to_s || "#{work_identifier}_sim"
end

# @return [String]
Expand All @@ -102,7 +102,7 @@ def related_parents_raw_mapping
# @return [String]
# @see #related_parents_field_mapping
def related_parents_parsed_mapping
@related_parents_parsed_mapping ||= (get_field_mapping_hash_for('related_parents_field_mapping')&.keys&.first || 'parents')
@related_parents_parsed_mapping ||= get_field_mapping_hash_for('related_parents_field_mapping')&.keys&.first || 'parents'
end

# @return [String, NilClass]
Expand All @@ -114,7 +114,7 @@ def related_children_raw_mapping
# @return [String]
# @see #related_children_raw_mapping
def related_children_parsed_mapping
@related_children_parsed_mapping ||= (get_field_mapping_hash_for('related_children_field_mapping')&.keys&.first || 'children')
@related_children_parsed_mapping ||= get_field_mapping_hash_for('related_children_field_mapping')&.keys&.first || 'children'
end

# @api private
Expand Down