Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forces to require Sufia version 4.x #658

Merged
merged 1 commit into from
Aug 28, 2014
Merged

Forces to require Sufia version 4.x #658

merged 1 commit into from
Aug 28, 2014

Conversation

hectorcorrea
Copy link
Contributor

Forcing to require version 4.x of Sufia otherwise step rails generate sufia:install -f does not work.

@carolyncole
Copy link
Contributor

👍

@jcoyne
Copy link
Contributor

jcoyne commented Aug 28, 2014

I don't understand why this would be required. If you add gem 'sufia' to your gemfile and do bundle install then you will get Sufia 4.0. @hectorcorrea can you elaborate on the situation you are trying to rectify?

@hectorcorrea
Copy link
Contributor Author

@jcoyne when creating a Sufia application as indicated in the README you'll get an error executing rails generate sufia:install -f that says "Could not find generator sufia:install"

@mark-dce found that the problem goes away when we force the Gemfile to target 4.x

Without this change, when you run bundle install bundle seems to install the previous version 3.7.2 (don't know why)

@jcoyne
Copy link
Contributor

jcoyne commented Aug 28, 2014

$ rails new foo
      create
      create  README.rdoc
...
* bin/rake: spring inserted
* bin/rails: spring inserted
$ cd foo/
$ echo 'gem "sufia"' > Gemfile

$ bundle install
Resolving dependencies...
Using rake 10.3.2
...
Using sufia 4.0.0.beta2
Your bundle is complete!
Use `bundle show [gemname]` to see where a bundled gem is installed.

$ bundle --version
Bundler version 1.7.2

Hmm, it looks like Bundler is preferring already installed versions over the latest version on rubygems.

jcoyne added a commit that referenced this pull request Aug 28, 2014
Forces to require Sufia version 4.x
@jcoyne jcoyne merged commit 5b588bc into samvera-deprecated:master Aug 28, 2014
@jcoyne
Copy link
Contributor

jcoyne commented Aug 28, 2014

For in depth reading on this issue: rubygems/bundler#3089

@hectorcorrea
Copy link
Contributor Author

wow....bundler is far more complex and mysterious that I thought. Dependency management is hard.

@carolyncole carolyncole deleted the readme branch October 22, 2014 16:23
jcoyne pushed a commit that referenced this pull request Nov 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants