Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby-client ENABLE_NIL_PARSER: Previous technique worked under 1.9.1 but fails under 1.9.2/3 #23

Merged
merged 1 commit into from
Dec 21, 2011

Conversation

jawj
Copy link
Contributor

@jawj jawj commented Dec 18, 2011

No description provided.

samuraisam pushed a commit that referenced this pull request Dec 21, 2011
ruby-client ENABLE_NIL_PARSER: Previous technique worked under 1.9.1 but fails under 1.9.2/3
@samuraisam samuraisam merged commit c768026 into samuraisam:master Dec 21, 2011
@samuraisam
Copy link
Owner

Thanks for the bug fix

@krasio
Copy link

krasio commented Apr 20, 2012

Hi,

I dont see those fixes when gem is installed from rubygems.com. Last version there is from January 29, 2010.

Suggestion: it would be nice if that gem is extracted in it's own repo, this way one can install it from GitHub, instead of RubyGems. This way it would be easy to grab and use latest version or any other fork.

@samuraisam
Copy link
Owner

@krasio I'd love if you could fork it and make it so. I will link to it from the readme

@krasio
Copy link

krasio commented May 2, 2012

Here it is - https://github.com/krasio/pyapns_gem.

Named it PYAPNS in order not to duplicate with your own gem. I'll keep watching your repo in order to sync new changes when there are any.

If I find time I may try to add some tests and publish it on rubygems.org.

@samuraisam
Copy link
Owner

If you publish it on rubygems.org it'd be really very awesome

@samuraisam
Copy link
Owner

Is there any way for me to turn over the rubygems.org gem so your code can be pushed there?

@krasio
Copy link

krasio commented May 3, 2012

You can add me as owner. My rubygems email is krasio @ codingspree.net.

@samuraisam
Copy link
Owner

@krasio I have done exactly that. Thank you so much for your help!

@krasio
Copy link

krasio commented May 5, 2012

We say thank you for your work on pyapns :).

Our team is doing some changes on the gem, we'll test them for a while and then publish new version on rubygems.

ggarber pushed a commit to ggarber/pyapns that referenced this pull request Nov 8, 2012
ruby-client ENABLE_NIL_PARSER: Previous technique worked under 1.9.1 but fails under 1.9.2/3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants