Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for Proxy creation from URL String and SOCKS5 authentication #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixes for Proxy creation from URL String and SOCKS5 authentication #2

wants to merge 4 commits into from

Conversation

kalorz
Copy link

@kalorz kalorz commented Feb 13, 2013

  • Fixed Proxifier::Proxy creation from URL String (Proxifier::Proxy.new('socks://user:password@domain:port')).
  • Fixed SOCKS5 authentication (it lacked subnegotiation version required by protocol specified in RFC 1928 and RFC 1929).
  • Added tests for above fixes.

@willglynn
Copy link

+1.

@subimage
Copy link

+1 please merge

@diogopublio
Copy link

it would be great to have it merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kalorz @willglynn @subimage @diogopublio