This repository has been archived by the owner on Jul 21, 2021. It is now read-only.
allows a channel to be re-used across multiple watches #151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to be able to setup multiple watches and more carefully control how watch logic is dispatched. With the existing APIs, which always create single-shot channels, I had two choices:
reflect.Select(...)
) so that a single goroutine can try to consume events from all of the watch channels. This goroutine can then decide how to dispatch. There is non-trivial overhead in both performance and in terms of cognitive overhead as the resulting code is more complex. The overhead arises from both the use of reflection and the need to manage the set of watches in a correct way.Neither of these is ideal to me. Also, neither allow me to receive events in an order that is guaranteed to be the same as the order they were delivered from Zookeeper (which has nice properties in terms of reasoning about the order of events received, including potentially redundant events, when doing something like watching an entire sub-tree).
This pull request provides new API with very small surface area:
GetWChannel
,ChildrenWChannel
, andExistsWChannel
that allow the caller to provide the channel that will be used to send the watch event.