Allow repeated invocations of bcf_update_info/format_*() #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than asserting that no value has previously been set, free any previously set value array before unpacking the new one. Fixes samtools#813. (This free() is all that's left after duplicating the "Mark the tag for removal, free existing memory if necessary" code from earlier in each function, and removing assignments that are unnecessary due to the immediately following bcf_unpack_info/fmt_core1() call.) Add test cases that update to small, large, and finally middle-sized values, so that both reallocation and reuse are exercised.
|
Looks like #813 dropped off our radar slightly. Thanks for fixing it. |
|
No problem. I was pleasantly surprised that the whole thing evaporated down to just one line! |
|
Thanks for this fix. I’ve been too busy to get to it. Any idea when the next release is scheduled? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed this for something else, hence… Rather than asserting that no value has previously been set, free any previously set value array before unpacking the new one. Fixes #813.
(This free() is all that's left after duplicating the "Mark the tag for removal, free existing memory if necessary" code from earlier in each function, and removing assignments that are unnecessary due to the immediately following bcf_unpack_info/fmt_core1() call.)