Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fuzz integer overflow in cram encoder. #1775

Merged
merged 1 commit into from
May 2, 2024
Merged

fix fuzz integer overflow in cram encoder. #1775

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions cram/cram_io.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1984,11 +1984,15 @@ int cram_compress_block2(cram_fd *fd, cram_slice *s,
// We also get large fluctuations based on genome coordinate for
// e.g. SA:Z and SC series, but we consider the typical scale of
// delta between blocks and use this to look for abnormality.

// Equivalent to (but minus possible integer overflow)
// (b->uncomp_size + 1000)/4 > metrics->input_avg_sz+1000 ||
// b->uncomp_size + 1000 < (metrics->input_avg_sz+1000)/4)
if (metrics->input_avg_sz &&
(b->uncomp_size + 1000 > 4*(metrics->input_avg_sz+1000) ||
b->uncomp_size + 1000 < (metrics->input_avg_sz+1000)/4) &&
ABS(b->uncomp_size-metrics->input_avg_sz)
> 10*metrics->input_avg_delta) {
(b->uncomp_size/4 - 750 > metrics->input_avg_sz ||
b->uncomp_size < metrics->input_avg_sz/4 - 750) &&
ABS(b->uncomp_size-metrics->input_avg_sz)/10
> metrics->input_avg_delta) {
metrics->next_trial = 0;
}

Expand Down