Add "uncompressed" in hts_format_description() where appropriate #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For formats like BAM and BCF that are normally compressed, report it explicitly when encountering a raw uncompressed such file. See samtools/samtools#1884 for motivation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In samtools/samtools#1884 we saw a BAM file downloaded via a web browser and ungzipped.
htsfilereported this file as follows:In isolation it's not obvious that this is reporting that the BAM file is not BGZF-compressed as normal. (For usual BAM files,
htsfilereportsBAM version 1 compressed sequence data, but if you don't have one handy to compare…)This PR adds “uncompressed” for uncompressed files in formats, like BAM and BCF, that are normally compressed, to make this clear. Thus: