Base mod test harness bug fixes / improvements #1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove line from base-mods.sh which caused it to always return success. * Explicitly check for non-zero return from base mod tests that are expected to work that way.
Stop test/test_mod from writing trailing whitespace, to make commiting the outputs easier for developers using pre-commit checks for whitespace issues. Remove array `out`, as it's contents were never used, or even set due to conditionals on argc. This also allows the output to be written directly to stdout instead of going through an intermediate buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simple_test_driver.shbetter at cleaning up its temporary filestest/base_mods/base-mods.shalways return successtest/test_modby removing some dead code and writing the output directly instead of via an intermediate buffer.test/test_modfrom putting tabs/spaces on the ends of lines, which are annoying if you're usinggit diff-index --checkin a pre-commit hook to catch that sort of thing.