Prevent spurious and random system errors from test_bgzf.c #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test script is expected to fail as it's testing both working and failing conditions, but the test harness prints up strerror(errno), which is usually some unrelated event and the text also differs per platform. Also, as per 1.16, changed it so the things that are expected to fail no longer complain. Given some of the new diagnostics added to bgzf.c, this requires manipulation of the global htslib log level.
jkbonfield
force-pushed
the
bgzf_test_errs
branch
from
75d3cbc to
33b92be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test script is expected to fail as it's testing both working and failing conditions, but the test harness prints up strerror(errno), which is usually some unrelated event and the text also differs per platform.