Fix hts_parse_decimal and make synced BCF targets parsing more robust #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whops, did not pass htslib tests... |
The function bcf_sr_regions_init() autodetects the format of input regions, trying to decide between CHR,POS vs CHR,BEG,END formats. However, the function hts_parse_decimal() was recognising standalone `G` as `0` which resulted in `chr1 1234 G` being interpretted as `chr1 1234 0`. This commit makes the digit parsing more strict, requiring at least one digit to appear before the exponent or unit part. See also samtools/bcftools#1598
pd3
added a commit
to samtools/bcftools
that referenced
this pull request
Feb 14, 2022
Note this fails until samtools/htslib#1396 is merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function bcf_sr_regions_init() autodetects the format of input regions,
trying to decide between CHR,POS vs CHR,BEG,END formats. However, the function
hts_parse_decimal() was recognising standalone
Gas0which resulted inchr1 1234 Gbeing interpretted aschr1 1234 0.This commit makes the digit parsing more strict, requiring at least one digit
to appear before the exponent or unit part.
See also samtools/bcftools#1598