Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No OAuth Support #1

Open
pyro2927 opened this issue Nov 13, 2013 · 12 comments
Open

No OAuth Support #1

pyro2927 opened this issue Nov 13, 2013 · 12 comments
Milestone

Comments

@pyro2927
Copy link
Contributor

OAuth is best. More secure.

Gold iPhone guy

I actually have been making something extremely similar for my OS X menubar inbox notifier. I'll see if I can fork RedditKit tonight and drop in my OAuth code.

@pyro2927
Copy link
Contributor Author

@samsymons: does this flow with the existing code style? Don't want to get far down the path and then have to refactor it all
pyro2927@bc64b9c

@samsymons
Copy link
Owner

@pyro2927 Yep, this is looking great so far – nice work.

@pyro2927
Copy link
Contributor Author

I worked a little bit more on it this morning and broke it out into it's own subclass, trying to keep things as clean as possible. It was also somewhat necessary since OAuth calls use a different base URL.

I've got it mostly working, though there are some projects with getting 401s when logging in. Hopefully I can fix those soon!

@pyro2927
Copy link
Contributor Author

Logging in working. Up next: automatically refreshing access tokens (as they expire after 1hr).

@samsymons
Copy link
Owner

@pyro2927 Thanks for this by the way – it's a huge help.

@samsymons samsymons modified the milestone: 2.0 Sep 8, 2014
@jonandersen
Copy link

@samsymons Is there any ETA on OAuth support? I'm planning to add Reddit into an app soon and saw that current licensing only allows for OAuth http://www.reddit.com/wiki/licensing. Do you need help with anything to finish it?

@h0jeZvgoxFepBQ2C
Copy link

Any ETA for this? would need this in my application... Thanks!

CorruptCanary pushed a commit to CorruptCanary/RedditKit that referenced this issue Aug 30, 2015
@zakkhoyt
Copy link

Also would like.

@nicklanasa
Copy link

@pyro2927 OAuth support is required by March of 2016. Is there anything the community can do to help move to forward faster? I would even help myself.

@pyro2927
Copy link
Contributor Author

@nicklanasa, I haven't touched this in a while. I know @samsymons had it going on this branch.

@nicklanasa
Copy link

@samsymons What's the status of the branch? Anything I can help with? My app is using this wrapper now and would be nice to have it in before it breaks login for me. @pyro2927 Thanks for the update.

@AaronKovacs
Copy link

@pyro2927 how far behind is your OAuth branch is it feasible for me to try and merge it into my own fork?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants