Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fates_harvest_mode to use characters for namelist option select #3

Merged

Conversation

glemieux
Copy link

@glemieux glemieux commented May 13, 2024

Description of changes

Updating the harvest mode namelist option definition to use char instead of int per E3SM-Project/E3SM#6353 (comment).

Specific notes

Testing performed, if any:

Builds successfully.

@glemieux glemieux changed the base branch from master to fates-landuse-v2 May 13, 2024 18:23
@glemieux glemieux changed the title Update fates_harvest_mode to use characters for namelist option select [WIP] Update fates_harvest_mode to use characters for namelist option select May 13, 2024
glemieux added 7 commits May 13, 2024 15:05
If luh + fbg are present fail if flandusepftdat isn't valid.
Don't allow fluh_timeseries to be defined if in potential veg mode
to avoid confusing users that it is needed.
@glemieux
Copy link
Author

glemieux commented May 16, 2024

Currently run testing this on derecho. Just waiting on the queue.

@glemieux glemieux changed the title [WIP] Update fates_harvest_mode to use characters for namelist option select Update fates_harvest_mode to use characters for namelist option select May 16, 2024
@glemieux
Copy link
Author

This successfully ran for one year with fates_harvest_mode = 'luhdata_area'.

@glemieux
Copy link
Author

This also runs for the fates_harvest_mode = 'surfdata_file' mode.

samsrabin pushed a commit that referenced this pull request May 22, 2024
updating input data file paths
@samsrabin samsrabin merged commit 0676cf3 into samsrabin:fates-landuse-v2 May 22, 2024
@glemieux glemieux deleted the fates-landuse-v2-fhm-chars branch May 23, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants