-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add browser platform #84
Conversation
@marcel-ernst please back out the CHANGELOG and version bump changes |
ok, check it now. |
Any progress ? |
Would love to see this merged in as well. |
Sorry, How can i install this version? |
Can you merge this please? I just spent hours debugging my tests, until I noticed they fail because of this. |
@richsage any plan for a new release with this PR ? |
@cadesalaberry afraid I don't work at White October anymore - probably one for @WoJBurgess |
This looks good to me, Can anyone who uses a Browser build confirm the core functions work with this PR? @marcel-ernst if you have a hosted version anywhere that would be good enough for me.. |
Any news on this being merged? |
Yep just added this to my app and it works fine in browser with this patch |
Thanks for this, @marcel-ernst, and to everyone who tested. I've merged this now as you'll see, and have created a release to include it: https://github.com/whiteoctober/cordova-plugin-app-version/releases/tag/0.1.10 Note that, although I've got write permissions on this repository, I'm not a maintainer for this project - #100 still applies - I just merged this as it seemed simple, in-demand and well-tested. |
have fun