Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide action button after uninstalling or restoring apps #161

Merged
merged 5 commits into from
Feb 19, 2025

Conversation

coderang-gk
Copy link
Contributor

@coderang-gk coderang-gk commented Feb 18, 2025

Fixes #160 floating action button remained visible after uninstalling or restoring apps, even when no apps were selected. This fix ensures the button properly disappears when the selection is empty.

Copy link
Owner

@samolego samolego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do you actually use isSelectionMode? Also, can't we just edit the CantaApp#MainContent and, as you've already done, the AppListViewModel?

@samolego
Copy link
Owner

@coderang-gk coderang-gk requested a review from samolego February 19, 2025 07:04
Copy link
Owner

@samolego samolego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you have tested & built the apk too?

@coderang-gk
Copy link
Contributor Author

I assume you have tested & built the apk too?

yes, works fine

@samolego samolego merged commit c2f5986 into samolego:master Feb 19, 2025
1 check passed
@samolego
Copy link
Owner

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants