Revamp build system #126
Closed
Revamp build system #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes issues related to the dual-packaging of CJS and ESM modules, and uses `tsup` to simplify and speed up the build process. The key changes are: - CJS, ESM, and declaration files are all outputted to `./dist`. - CJS files have `.js` extension, while EMS file have `.mjs`. This guarantees compatibility with Node's module resolution system. - `pkg.exports` reflects the new `dist/` structure. - `tsconfig.json` extends the Node14 tsconfig base. - `tsconfig.build-cjs.json` and `tsconfig.build-esm.json` are not needed and have been removed. - `tsconfig.build-types.json` is still needed as `tsup` output results in chunked files and removes comments.
|
@samhh anything I can do to help get this merged? |
|
Hey @andreavaccari! Sorry for my slow follow up, I've been mostly AFK the last few weeks. It would be helpful for me to know what exactly tsup is doing differently under the hood. On the plus side it's very tempting for me to offload all this bundling stuff to a third party like this... 😉 |
|
Closing as stale. Happy to revisit if there's interest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #113 and #118