-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker Swarm config file, and Swarm & compose config file support #1540
Add Docker Swarm config file, and Swarm & compose config file support #1540
Conversation
7f8c397
to
b137dd2
Compare
README.md
Outdated
file: ./gitlab.secrets | ||
``` | ||
|
||
If you're only using one of these files, don't include its entries in the docker-compose file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean "If you're not using one of these files, then don't include its entry in the docker-compose file"? It's a little confusing as currently worded.
b137dd2
to
a2d7efb
Compare
a2d7efb
to
4542234
Compare
4542234
to
d244882
Compare
what do you think @solidnerd ? |
Hey @SvenDowideit, thanks for your work. I think it is a nice cool idea to support that. I would like to see this as an additional content so for this case I would like to have it as feature. That means I think we should also need to set an environment variable that allows us to use this feature something like WDYT ? |
d244882
to
18da2d2
Compare
@solidnerd idk - wrt moving the contrib - can do... |
ce18316
to
244eed7
Compare
Signed-off-by: Sven Dowideit <[email protected]>
244eed7
to
474fe9f
Compare
I think we will support this for 10.8.0 and yes you have right an extra env will make this redundant . I tested it and it's working for me. Thanks for the work ;) |
@solidnerd awesome! looking forward to it :) |
for #1362
see README.md changes for how&what it does
can be tested using the image at
svendowideit/docker-gitlab