Skip to content

Commit

Permalink
RomanNumerals supports parse method
Browse files Browse the repository at this point in the history
`RomanNumerals` supports `parse` method. So no need to include it here.
  • Loading branch information
sambitdash authored Aug 23, 2017
1 parent 2754aec commit 6d6aaac
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/ExtNumerals.jl
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
# Regex to validate a Roman numeral
using RomanNumerals

Base.parse(::Type{RomanNumeral}, str::String) = RomanNumeral(str)

Base.string(num::LabelNumeral{Int}) = begin
sval = num.val |> Base.string
if num.caselower
Expand Down

1 comment on commit 6d6aaac

@tkelman
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but only starting in v0.2.2 anthonyclays/RomanNumerals.jl@867f09f, right? should add a minimum version requirement in REQUIRE then amend the tag, see https://github.com/attobot/attobot#updatingdeleting-a-release

Please sign in to comment.