Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster-glusterfs: Disable disperse volume operations #61

Closed

Conversation

anoopcs9
Copy link
Collaborator

@anoopcs9 anoopcs9 commented Nov 12, 2023

Test runs on disperse volumes doesn't proceed after a hung state and eventually gets timed out(6 hrs from CentOS CI maximum reservation time). Therefore limit the tests runs to just distribute-replicated volumes which seems to pass without any issues.

@anoopcs9 anoopcs9 marked this pull request as ready for review November 12, 2023 11:13
@anoopcs9 anoopcs9 requested a review from xhernandez November 12, 2023 11:13
@anoopcs9 anoopcs9 force-pushed the gfs-disable-disperse-vol branch from 24a2aaf to 0310af3 Compare November 12, 2023 11:15
@anoopcs9 anoopcs9 force-pushed the gfs-disable-disperse-vol branch from 0310af3 to 3ac218d Compare November 13, 2023 09:56
@spuiuk
Copy link
Collaborator

spuiuk commented Nov 13, 2023

I don't see the point of continuing with replicated volume testing only if we don't intend on fixing problems we hit. Maybe we should probably switch off glusterfs testing in centos-ci instead. That way the code to do a more comprehensive test of glusterfs code is still available in easy reach.

@spuiuk
Copy link
Collaborator

spuiuk commented Nov 13, 2023

From the meeting today -
We investigate the cause of this problem to rule out issues in the test environment.
We don't merge this PR.
We run CentOS CI tests for glusterfs only for nightly runs and not for every PR.
We investigate if we can manually set a label(or other mechanism) to tell the CI system that the changes should also be tested against GlusterFS.

@anoopcs9
Copy link
Collaborator Author

anoopcs9 commented Nov 13, 2023

From the meeting today - We investigate the cause of this problem to rule out issues in the test environment. We don't merge this PR.

Did you mean to investigate the hung state on running test suite for disperse volumes?

We run CentOS CI tests for glusterfs only for nightly runs and not for every PR. We investigate if we can manually set a label(or other mechanism) to tell the CI system that the changes should also be tested against GlusterFS.

Above suggestion is already available for review as samba-in-kubernetes/samba-centosci#42. Awaiting reviews..

@spuiuk
Copy link
Collaborator

spuiuk commented Nov 14, 2023

From the meeting today - We investigate the cause of this problem to rule out issues in the test environment. We don't merge this PR.

Did you mean to investigate the hung state on running test suite for disperse volumes?

Yes. Xavi offered to investigate when he has some time. This can take some time now that we have disabled glusterfs testing with each PR.(See below)

We run CentOS CI tests for glusterfs only for nightly runs and not for every PR. We investigate if we can manually set a label(or other mechanism) to tell the CI system that the changes should also be tested against GlusterFS.

Above suggestion is already available for review as samba-in-kubernetes/samba-centosci#42. Awaiting reviews..

Thanks - Acked and Mer

@anoopcs9
Copy link
Collaborator Author

From the meeting today - We investigate the cause of this problem to rule out issues in the test environment. We don't merge this PR.

Did you mean to investigate the hung state on running test suite for disperse volumes?

Yes. Xavi offered to investigate when he has some time. This can take some time now that we have disabled glusterfs testing with each PR.(See below)

Why don't we then take in the change so that nightly runs can complete on just distribute-replicate volumes without getting timed out?

@xhernandez
Copy link
Collaborator

@anoopcs9 if we merge this PR, then there won't be any way to run disperse tests on centos-ci, right ?

To investigate the cause, I will need to be able to run some tests.

Is it possible to temporarily disable glusterfs tests on nightly builds ?

@anoopcs9
Copy link
Collaborator Author

From the meeting today - We investigate the cause of this problem to rule out issues in the test environment. We don't merge this PR.

Did you mean to investigate the hung state on running test suite for disperse volumes?

Yes. Xavi offered to investigate when he has some time. This can take some time now that we have disabled glusterfs testing with each PR.(See below)

samba-in-kubernetes/sit-test-cases#45 will further track the progress on hung issue with disperse volumes. Therefore abandoning the PR as investigation is underway to root cause the hung state.

@anoopcs9 anoopcs9 closed this Nov 15, 2023
@anoopcs9 anoopcs9 deleted the gfs-disable-disperse-vol branch November 22, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants