Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check commit messages with gitlint #75

Merged
merged 3 commits into from
Apr 18, 2023

Conversation

phlogistonjohn
Copy link
Collaborator

Add a tox environment for checking commits with gitlint. Add a CI job for checking

Depends on: #74

@dpulls
Copy link

dpulls bot commented Apr 12, 2023

🎉 All dependencies have been resolved !

@mergify
Copy link

mergify bot commented Apr 12, 2023

This pull request now has conflicts with the target branch. Please resolve these conflicts and force push the updated branch.

@phlogistonjohn
Copy link
Collaborator Author

This should be good to be reviewed minus the intentional failing commit. Once I get at least one vague thumbs up I'll remove the bad commit and take it out of draft.

synarete
synarete previously approved these changes Apr 18, 2023
Copy link
Collaborator

@synarete synarete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with the exception of the last test-only commit)

@mergify mergify bot dismissed synarete’s stale review April 18, 2023 13:23

Pull request has been modified.

@phlogistonjohn phlogistonjohn marked this pull request as ready for review April 18, 2023 13:23
Copy link
Collaborator

@synarete synarete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@obnoxxx
Copy link
Contributor

obnoxxx commented Apr 18, 2023

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Apr 18, 2023

rebase

❌ Unable to rebase: user obnoxxx is unknown.

Please make sure obnoxxx has logged in Mergify dashboard.

The new gitlint tox environment is not run by default, it can be run
manually or by CI in order to check that commit messages meet some basic
quality criteria.

Signed-off-by: John Mulligan <[email protected]>
Add a simple gitlint configuration file.

Signed-off-by: John Mulligan <[email protected]>
@mergify mergify bot merged commit c81c65a into samba-in-kubernetes:master Apr 18, 2023
@phlogistonjohn phlogistonjohn deleted the jjm-gitlint branch April 18, 2023 18:15
@anoopcs9 anoopcs9 changed the title WIP: check commit messages with gitlint Check commit messages with gitlint Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants