-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check commit messages with gitlint #75
Check commit messages with gitlint #75
Conversation
8dbb825
to
4a757fc
Compare
🎉 All dependencies have been resolved ! |
This pull request now has conflicts with the target branch. Please resolve these conflicts and force push the updated branch. |
4a757fc
to
d78127c
Compare
This should be good to be reviewed minus the intentional failing commit. Once I get at least one vague thumbs up I'll remove the bad commit and take it out of draft. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (with the exception of the last test-only commit)
d78127c
to
fbb44a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@Mergifyio rebase |
❌ Unable to rebase: user
|
The new gitlint tox environment is not run by default, it can be run manually or by CI in order to check that commit messages meet some basic quality criteria. Signed-off-by: John Mulligan <[email protected]>
Add a simple gitlint configuration file. Signed-off-by: John Mulligan <[email protected]>
Signed-off-by: John Mulligan <[email protected]>
fbb44a3
to
07d8687
Compare
Add a tox environment for checking commits with gitlint. Add a CI job for checking
Depends on: #74