Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github actions: test container build on PRs #27

Merged
merged 4 commits into from
Feb 8, 2021
Merged

github actions: test container build on PRs #27

merged 4 commits into from
Feb 8, 2021

Conversation

obnoxxx
Copy link
Collaborator

@obnoxxx obnoxxx commented Feb 7, 2021

Signed-off-by: Michael Adam [email protected]

@obnoxxx
Copy link
Collaborator Author

obnoxxx commented Feb 7, 2021

After merging PR #26, I noticed that the push action failed on the container build with no space left on device.
Therefore, I am adding the container build to the PR tests as well (not the push though...).

@obnoxxx obnoxxx enabled auto-merge (rebase) February 7, 2021 19:33
@obnoxxx obnoxxx force-pushed the build-image-in-ci branch 2 times, most recently from c9a87a5 to 6ce11d1 Compare February 7, 2021 21:47
@obnoxxx
Copy link
Collaborator Author

obnoxxx commented Feb 7, 2021

OK, this doesn't really pass. I just added an || df -h after the make command.
It fails with no space left, but the df does not seem to confirm that... 🤷

@obnoxxx obnoxxx added the do not merge do not merge label Feb 7, 2021
@obnoxxx
Copy link
Collaborator Author

obnoxxx commented Feb 7, 2021

OK... Added a docker build flavour, and that passes...
Not sure what's up with podman and space consumption.

@obnoxxx
Copy link
Collaborator Author

obnoxxx commented Feb 8, 2021

OK, so ...

  • container build using docker works
  • container build using podman fails due to no space left on device

@phlogistonjohn , should we just use docker for now, and have a PR check job for both podman and docker?

@obnoxxx
github actions: test container build with podman on PRs
81047f5 
Signed-off-by: Michael Adam <[email protected]>
@obnoxxx
github actions: podmanbuild: some free space debugging
b49ab45 
Jobs are failing due to "no space left on device" when building
the container image. Adding some df output.

See: actions/runner-images#709

Signed-off-by: Michael Adam <[email protected]>
@obnoxxx
github actions: test container build with docker on PRs
543b543 
Signed-off-by: Michael Adam <[email protected]>
@obnoxxx
github actions: publish the images using docker
0fbbe5e 
Podman currently has an issue with space consumption that lets
the image build fail with "no space left on device".
Therefore falling back to using docker for now, which works.

Signed-off-by: Michael Adam <[email protected]>
@obnoxxx
Copy link
Collaborator Author

obnoxxx commented Feb 8, 2021

@phlogistonjohn, I changed this to:

  1. build with both podman and docker in PR verification (podman currently fails)
  2. change the push job to use docker (which should work for now)

@phlogistonjohn
Copy link
Collaborator

@phlogistonjohn, I changed this to:

1. build with both podman and docker in PR verification (podman currently fails)

2. change the push job to use docker (which should work for now)

Sounds good.
As for the podman issue itself we should check what version these builder vms come with. We could also see if we can pull in a newer release if its old, and see if that improves things. If not, perhaps we should report the issue.

@obnoxxx
Copy link
Collaborator Author

obnoxxx commented Feb 8, 2021

@phlogistonjohn, I changed this to:

1. build with both podman and docker in PR verification (podman currently fails)

2. change the push job to use docker (which should work for now)

Sounds good.

Should we push it as is then and let the podman build fail for now?

As for the podman issue itself we should check what version these builder vms come with. We could also see if we can pull in a newer release if its old, and see if that improves things. If not, perhaps we should report the issue.

actions/runner-images#709
actions/runner-images#1860
containers/podman#3846

@obnoxxx obnoxxx merged commit 0dd8fab into samba-in-kubernetes:master Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phlogistonjohn phlogistonjohn phlogistonjohn approved these changes

Assignees
No one assigned
Labels
do not merge do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@obnoxxx @phlogistonjohn