[MRG] Fix indexing for batch simulations #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: samadpls <[email protected]>
Signed-off-by: samadpls <[email protected]>
Signed-off-by: samadpls <[email protected]>
Signed-off-by: samadpls <[email protected]>
Signed-off-by: samadpls <[email protected]>
Co-authored-by: Nicholas Tolley <[email protected]> Signed-off-by: samadpls <[email protected]>
Co-authored-by: Nicholas Tolley <[email protected]> Signed-off-by: samadpls <[email protected]>
Signed-off-by: samadpls <[email protected]>
|
I might be forgetting about an edge case so be sure to check over the logic of this |
samadpls
force-pushed
the
feat/batch_simulation
branch
from
9f6413a to
ebdeeea
Compare
samadpls
added a commit
that referenced
this pull request
Dec 3, 2024
* ENH BatchSimulate for JSON path handling Signed-off-by: samadpls <[email protected]> * Fix: Docstring of dic_to_network Signed-off-by: samadpls <[email protected]> * ENH: Reorder the init params Signed-off-by: samadpls <[email protected]> * Added record_isec vsec validation test Signed-off-by: samadpls <[email protected]> * Removed net_json param and update test Signed-off-by: samadpls <[email protected]> * Refactored Example and initialize parameters Co-authored-by: Nicholas Tolley <[email protected]> Signed-off-by: samadpls <[email protected]> * Enh: visualization of dipole responses in plot_batch_simulate Co-authored-by: Nicholas Tolley <[email protected]> Signed-off-by: samadpls <[email protected]> * Refactor batch simulation parameters and backend Signed-off-by: samadpls <[email protected]> * batches run in parallel --------- Signed-off-by: samadpls <[email protected]> Co-authored-by: samadpls <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know if these changes make sense!