-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Enumerable to Stream #26
Conversation
examples/lib/stream-processing.ts
Outdated
@@ -120,7 +120,7 @@ const stream = queue.enumerable() // enumerable gives us a nice chainable API fo | |||
}; | |||
} | |||
}) | |||
.toStream(stack, 'Stream', { | |||
.toKinesis(stack, 'Stream', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any thoughts on toKinesis
vs toKinesisStream
? I.e. should I include the resource type as a suffix?
toSQS
ortoSQSQueue
toSNS
ortoSNSTopic
toKinesis
ortoKinesisStream
toS3DeliveryStream
ortoFirehose
toGlue
ortoGlueTable
(note: it's alreadytoGlueTable
, so we need to change it for consistency reasons)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it makes sense just to be a little more verbose to where it's going to, LGTM.
to{Service}{Resource}
is a good convention, makes it easier to reason. thinking about those services such as SageMaker that have a lot of underlying resources (although couldn't visualize a toSageMaker{Resource}
from the top of my head)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think this is a good convention. Updated to reflect that.
I'm not that happy with toS3DeliveryStream
. Could have gone with toFirehoseDeliveryStream
, but how to differentiate between destinations (Redshift, ElasticSearch, Splunk, etc.) Created #31 to follow up.
While we're namespacing all the things, should |
import * as DynamoDB from './dynamodb'; | ||
|
||
export { | ||
DynamoDB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a neat trick!
yeah, Function is a global constructor for function, would be good to go ahead and namespace that as well, and make it obvious it's a Lambda Function (and even sounds cooler haha) |
Fixes #25
Enumerable
toStream