-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3007.x] fix regression in master publish ipc socket #66752
Conversation
I see the needs testcase has been added. I'll try and figure that out. I'm not confident in my understanding of the test suite. I think that I'll need a test case for each transport to ensure that each one creates a permissive socket. Am I on the right track? If you could point me to some similar tests that would be helpful. I'm also not sure how to ensure that the socket doesn't already exist due to previous tests. I guess I just delete the file before the start of the tests? |
the publisher needs to be open not the puller
I believe I have some working tests. A few things to point out.
|
Closing in favor of #66805 |
Fixes #66228
Though the sockets /may/ need to be deleted or permission changed if they already exist. Not sure if the code will change the permissions when websocket / tcp transport is selected.