[master] Report failures and error information from tuned module #65720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
3 tasks
dwoz
previously approved these changes
Dec 18, 2023
|
@leeclemens This has pre-commit and linter failuers. |
|
@leeclemens Also looks like there are some tuned test failures now, At least on windows, the others have not finished yet. |
|
I'm working on porting the unit tests to pytest |
leeclemens
force-pushed
the
60500/tuned
branch
from
d73b8a4
to
48cc58f
Compare
I overlooked some changes with the pytest port (running now), but I'm not sure about tuned on Windows? |
dwoz
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replace stdout in cases of success with known value for state to evaluate.
Update response handling in states.
Returns cmd results from module for better processing and error handling.
Update to use pytests
What issues does this PR fix or reference?
Fixes: #60500
Previous Behavior
Errors were ignored and cmd output was ignored, specifically from the state. State was reported as successful/changed in some failed executions.
New Behavior
The module returns the full output from the cmd and modifies it when useful (success with the new expected profile being returned in stdout). Report failed execution as failure back to state.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.